fix: [DHIS2-15782] navigation with program stage filter #3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3431--dhis2-capture.netlify.app |
geethaalwan
approved these changes
Oct 16, 2023
dhis2-bot
added a commit
that referenced
this pull request
Oct 16, 2023
## [100.41.3](v100.41.2...v100.41.3) (2023-10-16) ### Bug Fixes * [DHIS2-15782] navigation with program stage filter ([#3431](#3431)) ([8f7a017](8f7a017))
|
🎉 This PR is included in version 100.41.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
superskip
pushed a commit
that referenced
this pull request
Oct 27, 2023
superskip
pushed a commit
that referenced
this pull request
Oct 27, 2023
## [100.41.3](v100.41.2...v100.41.3) (2023-10-16) ### Bug Fixes * [DHIS2-15782] navigation with program stage filter ([#3431](#3431)) ([8f7a017](8f7a017))
simonadomnisoru
added a commit
that referenced
this pull request
Nov 8, 2023
simonadomnisoru
pushed a commit
that referenced
this pull request
Nov 8, 2023
## [100.41.3](v100.41.2...v100.41.3) (2023-10-16) ### Bug Fixes * [DHIS2-15782] navigation with program stage filter ([#3431](#3431)) ([8f7a017](8f7a017))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-15782
Tech summary
Ensure that the hook is only fired when navigating from the search page to the main page with a different WL selected. I added checks for:
selectedTemplateId !== currentTemplateId- check if a different working list has been selected by comparing selectedTemplateId (the value of the URL parameter) with currentTemplateId (which comes from redux store workingListsTemplates.selectedTemplateId)!viewPreloaded- used to discard the case when currentTemplateId is auuid()while saving a new WL